[ 
https://issues.apache.org/jira/browse/HDFS-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148523#comment-14148523
 ] 

Jing Zhao commented on HDFS-7131:
---------------------------------

Both the findbugs warning and the javac warning should be unrelated. I will 
commit the patch shortly.

> During HA upgrade, JournalNode should create a new committedTxnId file in the 
> current directory
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7131
>                 URL: https://issues.apache.org/jira/browse/HDFS-7131
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: qjm
>    Affects Versions: 2.4.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7131.000.patch, HDFS-7131.001.patch
>
>
> Currently while doing HA upgrade, we do not create a new committedTxnId file  
>   in the new current directory of JournalNode. And before we have the fix in 
> HDFS-7042, since the file channel is never closed, for any new journal we're 
> actually updating the committedTxnId file in the previous directory. This can 
> cause NN to fail to start while rollback.
> HDFS-7042 fixes the main part of the issue: the file channel inside of the 
> committedTxnId object gets closed thus later a new file can be created in the 
> current directory. But maybe it is still better to copy the content file 
> during the upgrade so that we can always use it for sanity check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to