[
https://issues.apache.org/jira/browse/HDFS-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162432#comment-14162432
]
Colin Patrick McCabe commented on HDFS-7014:
--------------------------------------------
bq. I appreciate if the patch can be further split into smaller pieces. Is it
possible take out FileSystem / BlockReader / LeaseRenewer into separate patches?
I think probably BlockReader could be split into its own patch. Perhaps
FileSystem and the namenode proxy as well.
bq. I implement an abstract base class for some important class also for
testability reason. It give the opportunity to inherit a mock class from the
base class and inject mock object to remove the dependencies for the tested
module and do unit test.
I don't feel that strongly about this, but I'd prefer to avoid the layer of
indirection if possible. It's bad for performance.
It seems like we could get the same test functionality using wrapper streams.
If it's necessary for the wrapper streams to access private members of the
wrapped streams, they could be made into friend classes.
bq. Please correct me if I'm wrong, the outputstream implements the writing
logic of Hadoop v1, it might not work with Hadoop 2. Maybe we can exclude it in
this patch?
Can you clarify what you mean by "the writing logic of Hadoop v1"? It seems to
include all the "BlockConstructionStage" stuff that Hadoop 2 had, as well as
pipeline recovery.
> Implement input and output streams to DataNode for native client
> ----------------------------------------------------------------
>
> Key: HDFS-7014
> URL: https://issues.apache.org/jira/browse/HDFS-7014
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Zhanwei Wang
> Assignee: Colin Patrick McCabe
> Attachments: 0001-HDFS-7014-001.patch, HDFS-7014.patch
>
>
> Implement Client - Namenode RPC protocol and support Namenode HA.
> Implement Client - Datanode RPC protocol.
> Implement some basic server side class such as ExtendedBlock and LocatedBlock
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
