[ 
https://issues.apache.org/jira/browse/HDFS-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163865#comment-14163865
 ] 

Colin Patrick McCabe commented on HDFS-7014:
--------------------------------------------

Hi Zhanwei, I'm going to assign this one to you since the code is yours 
originally.

{code}
+SET(HEADER 
+    client/BlockLocation.h
+    client/DirectoryIterator.h
+    client/FileStatus.h
+    client/FileSystem.h
+    client/FileSystemStats.h
+    client/InputStream.h
+    client/OutputStream.h
+    client/Permission.h
+    common/Exception.h
+    common/SharedPtr.h
+    common/XmlConfig.h
+)
{code}

Can we discuss exporting header files in a future JIRA?  I think that we will 
have to use great care when designing a C\+\+ API.  [~wheat9] has already 
raised some issues in HDFS-7207, and I think there are a lot more issues to 
discuss.  The more files we expose, the harder it will be to modify anything in 
the future, so I would like to expose as little as possible.  So let's discuss 
the C\+\+ API in a follow-on JIRA once this stuff is in.

{code}
+    ${R}/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/encryption.proto
+    ${R}/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/inotify.proto
{code}

Thanks for adding these.  Too bad we don't support encryption yet :)

{code}
change the interface of InputStream::open to
void open(FileSystem &fs,
              const char *path, bool verifyChecksum = true);
{code}

I guess this makes sense since {{FileSystem}} simply contains a {{shared_ptr}} 
to a {{FileSystemImpl}} and no other state.  We could equally well just copy it.

> Implement input and output streams to DataNode for native client
> ----------------------------------------------------------------
>
>                 Key: HDFS-7014
>                 URL: https://issues.apache.org/jira/browse/HDFS-7014
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Zhanwei Wang
>            Assignee: Zhanwei Wang
>         Attachments: 0001-HDFS-7014-001.patch, HDFS-7014-pnative.002.patch, 
> HDFS-7014.patch
>
>
> Implement Client - Namenode RPC protocol and support Namenode HA.
> Implement Client - Datanode RPC protocol.
> Implement some basic server side class such as ExtendedBlock and LocatedBlock



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to