[
https://issues.apache.org/jira/browse/HDFS-7207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169085#comment-14169085
]
Zhanwei Wang commented on HDFS-7207:
------------------------------------
bq. A slightly simpler (probably subjective) approach might be to wrap things
in the opposite way. That is, putting the error message / stack traces in the
Status object directly and let hdfsGetLastError to get the string.
I think this way is more straightfoward.
Another issue is how to deal with the constructor, since it has no return
value, what if the {{std::bad_alloc}} is throw in constructor? Currently the
way I can figure out is to
1) use the factory pattern
2) or add a flag member in the interface class to indicate error.
Any suggestion?
> libhdfs3 should not expose exceptions in public C++ API
> -------------------------------------------------------
>
> Key: HDFS-7207
> URL: https://issues.apache.org/jira/browse/HDFS-7207
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Colin Patrick McCabe
> Priority: Blocker
> Attachments: HDFS-7207.001.patch
>
>
> There are three major disadvantages of exposing exceptions in the public API:
> * Exposing exceptions in public APIs forces the downstream users to be
> compiled with {{-fexceptions}}, which might be infeasible in many use cases.
> * It forces other bindings to properly handle all C++ exceptions, which might
> be infeasible especially when the binding is generated by tools like SWIG.
> * It forces the downstream users to properly handle all C++ exceptions, which
> can be cumbersome as in certain cases it will lead to undefined behavior
> (e.g., throwing an exception in a destructor is undefined.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
