[
https://issues.apache.org/jira/browse/HDFS-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171826#comment-14171826
]
Hadoop QA commented on HDFS-7190:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674863/HDFS-7190.patch
against trunk revision cdce883.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8424//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8424//console
This message is automatically generated.
> Bad use of Preconditions in startFileInternal()
> -----------------------------------------------
>
> Key: HDFS-7190
> URL: https://issues.apache.org/jira/browse/HDFS-7190
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Konstantin Shvachko
> Assignee: Dawson Choong
> Labels: newbie
> Attachments: HDFS-7190.patch
>
>
> The following precondition is in the middle of startFileInternal()
> {code}
> feInfo = new FileEncryptionInfo(suite, version,
> ....
> Preconditions.checkNotNull(feInfo);
> {code}
> Preconditions are recommended to be used in the beginning of the method.
> In this case the check is no-op anyways, because the variable has just been
> constructed.
> Should be just removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
