[
https://issues.apache.org/jira/browse/HDFS-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172280#comment-14172280
]
Hudson commented on HDFS-7190:
------------------------------
SUCCESS: Integrated in Hadoop-Yarn-trunk #712 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/712/])
HDFS-7190. Bad use of Preconditions in startFileInternal(). Contributed by
Dawson Choong. (wheat9: rev 128ace10cdde4e966e30ac429c9a65ab8ace2d6c)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Bad use of Preconditions in startFileInternal()
> -----------------------------------------------
>
> Key: HDFS-7190
> URL: https://issues.apache.org/jira/browse/HDFS-7190
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Konstantin Shvachko
> Assignee: Dawson Choong
> Labels: newbie
> Fix For: 2.7.0
>
> Attachments: HDFS-7190.patch
>
>
> The following precondition is in the middle of startFileInternal()
> {code}
> feInfo = new FileEncryptionInfo(suite, version,
> ....
> Preconditions.checkNotNull(feInfo);
> {code}
> Preconditions are recommended to be used in the beginning of the method.
> In this case the check is no-op anyways, because the variable has just been
> constructed.
> Should be just removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
