[ 
https://issues.apache.org/jira/browse/HDFS-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172510#comment-14172510
 ] 

Colin Patrick McCabe commented on HDFS-7227:
--------------------------------------------

A little more background here: we use the official Java style guide, but with 
2-space indents.  I thought there was some text in there about short "if" 
statements being OK to do on one line, but I don't see it in the guide.  Maybe 
it was always an unofficial convention?  Certainly there are a lot of examples 
of this in the code.  Anyway I'm not that concerned either way, so let's use 
braces.

> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in 
> SpanReceiverHost
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-7227
>                 URL: https://issues.apache.org/jira/browse/HDFS-7227
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-7227.001.patch, HDFS-7227.002.patch
>
>
> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in 
> SpanReceiverHost



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to