[
https://issues.apache.org/jira/browse/HDFS-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177417#comment-14177417
]
Colin Patrick McCabe commented on HDFS-7227:
--------------------------------------------
bq. Tsuyoshi wrote: Hi Colin Patrick McCabe, Java coding style says that we
should avoid emitting braces:
Right. That's why I commented that "I thought there was some text in there
about short "if" statements being OK to do on one line, but I don't see it in
the guide."
bq. stack wrote: Patch LGTM +1.
Can I get another +1 on this? Since we're being pedantic :)
It's clear that the findbugs warning in AbstractDelegationTokenSecretManager is
not related, since this patch doesn't change that.
> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in
> SpanReceiverHost
> -------------------------------------------------------------------------------
>
> Key: HDFS-7227
> URL: https://issues.apache.org/jira/browse/HDFS-7227
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-7227.001.patch, HDFS-7227.002.patch
>
>
> Fix findbugs warning about NP_DEREFERENCE_OF_READLINE_VALUE in
> SpanReceiverHost
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
