Hi Vivek, On 03/23/2012 09:06 PM, Vivek Prakash wrote: > I have added --recursive (-R) option to `ls` command. I have attached > the patch for the same in this mail. > > Any feedback and suggestions on improvements are very welcome.
Thanks for sending the patch, I am going to try it out soon. Here are some first-sight nits that I noticed (the line numbers are lines of the patch file): First of all, good catch on line 268. Line 115 Is it really necessary to use all three dir_list, dir_listp and tmp to realloc dir_list? Lines 117, 174, 177 The proper way to break the long line is to use tabs to get to the same indentation level as the previous line and then add four spaces. Line 156 Here you are wrongly using spaces instead of tabs. Line 163 There is no space between if and the opening parenthesis. Line 164 There are some extra spaces instead of a tab. Line 181 There is no space between switch and the opening parenthesis. Lines 182, 292 I don't know if the original code was correct in this regard, but the case label should be at the same indentation level as the containing switch. Line 191 Spaces instead of tabs. Line 357 The static declarations IMHO should not go to the .h file, but rather to the .c file. Cheers, Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
