On 03/25/2012 09:07 PM, Vivek Prakash wrote: > There are indeed memory leaks. How foolish of me, that i didn't test the > code properly! I found that ls_recursive() also leaks subdir_path in > addition to those you mentioned. Sorry, I will take care of these things > in future. Thanks for taking the trouble to point them. The fixed > changes are now reflected > at http://bazaar.launchpad.net/~vivek-cs-iitr/helenos/ls/revision/1441 .
Indeed, the leaks in the built-in commands are especially bad because they accumulate in the hosting instance of bdsh. I merged this in mainline,1442 and in mainline,1443 I turned '-R' into '-r' because there is no need to be avoiding '-r' when it is available. Thanks for making this contribution! Now your name will literally be part of the HelenOS history forever :-) If you now do a fresh bzr branch bzr://bzr.helenos.org/mainline and then bzr vis, you will see how the merge went. Theoretically, you can now continue to push your private changes to your branch and these could be merged to mainline again in the future. You can also merge from mainline, but you cannot pull from it to your branch (nor you can push in the opposite direction), because the branches have already diverged. Cheers, Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
