Hi Tomas, thanks for the patch. Dne 25. března 2012 14:07 Tomáš Virgl <[email protected]> napsal(a): > Hello, > I added support for datetime information in generated FAT > (tools/mkfat.py). Until now there what #FIXME comment. > Can anyone please test it inside HelenOS, because I do not know how to > find out e.g. modification date of directory? > Whole compilation works fine. I just tried to mount the generated image under Linux using
mount -o loop -t vfat boot/distroot/boot/initrd.img tmp/ and it displays year 2088, 2nd of January. Does this happen on my computer only or can you reproduce this? As for (style of) the patch itself, I have a few comments * we are using underscore_naming * the part where you create the actual timestamp looks rather dense - do you think it would be possible to somehow improve that? * I guess it would be a bit faster (and also the line would not be that ugly long) if in the last hunk you would store result of os.stat to a local variable - Vojta > Is this enough for GSoC or should I add more? I will try add LFN > (issue #400), but currently I do not have time. > Best regards, > Tomáš Virgl > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel > _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
