> I have a few comments to your patch. > * we do use underscore_naming_for_variables, not camelCase > * we put space between if and the parenthesis > * your patch does not compile with latest mainline (str_uint64 was > renamed to str_uint64_t two days ago), but that was easy to fix ;-)
Thanks for the comments, I have corrected these as you suggested, please let me know if I missed anything. > What I would like to see is an option for counting characters or lines > instead of bytes. But this is really a wish, I definitely do not mean > that we won't accept your patch without that or that you have to > implement it. It may be a good exercise for someone else. I agree that characters or lines definitely would be more helpful and have thought about how to implement that, however I will probably hold off until after I have my application submitted :) Although counting bytes does come in handy for the hex view. Maybe offset/length would be more handy for hex viewing though. >> Also, how do you change from the kernel console back to a virtual >> console? Pressing the F1-11 buttons? (I need a new keyboard, the F >> buttons don't always work). > Type continue in there (or help to see list of existing commands). > Ah... that was what I was looking for, thanks. > You can edit the sources and > when you find your changes worth committing, you can copy the source > file to a mounted disk image and unmount it from HelenOS, mount it under > Linux and copy it out of the image and then commit the changes. As I > said, perhaps possible, but not quite straightforward... I think at some point I might implement a TFTP client for HelenOS. The coding should be trivial and it seems like it would work pretty well in the HelenOS environment. Anyway, the revised patch is attached, let me know what you think. Thanks, Taylor Killian
cat-r2.patch
Description: Binary data
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
