Hi Taylor, Dne 31. března 2012 0:52 Taylor Killian <[email protected]> napsal(a): >> I have a few comments to your patch. >> * we do use underscore_naming_for_variables, not camelCase >> * we put space between if and the parenthesis >> * your patch does not compile with latest mainline (str_uint64 was >> renamed to str_uint64_t two days ago), but that was easy to fix ;-) > > Thanks for the comments, I have corrected these as you suggested, > please let me know if I missed anything. Looks good to me. Thanks.
Actually, I already applied your patch in my branch [1] but I did not have time to merge it yet. I should have tell you that there is no need to send the patch again as I already "fixed" the issues. Sorry about that. Anyway, it looks that the commit is identical to your second patch :-). > >> You can edit the sources and >> when you find your changes worth committing, you can copy the source >> file to a mounted disk image and unmount it from HelenOS, mount it under >> Linux and copy it out of the image and then commit the changes. As I >> said, perhaps possible, but not quite straightforward... > > I think at some point I might implement a TFTP client for HelenOS. The > coding should be trivial and it seems like it would work pretty well > in the HelenOS environment. That would be cool :-). Thanks again for the patch. Tomorrow I will probably merge it (can't do it from the computer I am on now). - Vojta [1] https://code.launchpad.net/~vojtech-horky/helenos/misc > > Anyway, the revised patch is attached, let me know what you think. Thanks, > > Taylor Killian > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel > _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
