Hi Adam, thanks for the patch. I have a few comments.
Please, use the same C style as we do. In general, we are more generous with spaces than you were in your patch. We do put them around operators or after keywords (such as if or while). And it seems to me that there is one bug in your implementation. Specifier %5.0f shall print the number without the fractional part. But your implementation prints at least one digit. Unless you want to provide your own fix, I will probably fix these some time next week because this is something I would like to have merged into mainline. Thanks. - Vojta Dne 7. dubna 2012 16:05 Adam Saleh <[email protected]> napsal(a): > Sending my patch. Hopefully fixes trac.helenos.org/ticket/221 > > Adam > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/cgi-bin/listinfo/helenos-devel > _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
