On 01/15/2018 04:29 PM, Jiří Zárevúcky wrote: > On 15 January 2018 at 14:03, Jiri Svoboda <[email protected]> wrote: >> I agree that we shouldn't use non-reserved identifiers, because it's >> necessary to be standards conformant. However, using a _HELENOS prefix seems >> too paranoid. The worst that could happen is that upon a compiler upgrade we >> could get a conflict, but this is rather unprobable. No libc I know of does >> this. >> >> Solaris libc, GNU libc, libmusl all use header guard _STDIO_H for stdio.h >> >> I really wouldn't worry so much. Using _HELENOS prefix everywhere is just >> too ugly and has very little benefit. >> > > I was under the impression that both you and JJ are concerned about this > possibility of conflict. Hence the defensive prefix. If that impression was > incorrect, then I completely agree with you. :)
As far as header guards are concerned, I have grown fond of #pragma once. We have caught about 5 occurrences of copy-pasted or mismatched #ifndef X, #define X pairs in HelenOS. Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
