On 1/20/19 12:24 PM, Petr Pavlu wrote:
> On 14. Jan 19 23:43, Jakub Jermář wrote:
>> On 1/14/19 8:34 PM, Petr Pavlu wrote:
>>> I have created and maintain a small project that adds support for
>>> the 64-bit Arm architecture (AArch64) to HelenOS.
>>>
>>> Source code of the port is available on GitHub [1]. It targets
>>> the QEMU virt platform with Cortex-A57, PL011 (UART), GICv2
>>> (interrupt controller), VirtIO-SCSI CD-ROM and EDK2 (UEFI
>>> implementation). The port implements usual low-level bits needed
>>> to run HelenOS on some architecture (boot, kernel, uspace) and
>>> can successfully boot on the mentioned platform and run user
>>> space console applications.
>>>
>>> The port was created primarily for my learning purposes but might
>>> be useful for others and I wonder if there would be interest in
>>> me trying to upstream it in the official version of HelenOS.
>>>
>>> [1] https://github.com/setupji/helenos
>>
>> This is simply amazing! I briefly glanced through your changes, built
>> the toolchain and ran HelenOS/arm64. Truly a wonderful achievement!
>>
>> Indeed, we would be interested in having this upstreamed to HelenOS. I'd
>> suggest rebasing to the current master and then submitting a PR.
> 
> Excellent, I will start working on the rebase and first try
> submitting PRs for a few not strictly AArch64-specific changes
> and then cut the remaining parts into a set of patches so they
> can be easily reviewed.

I would suggest not to overdo this. Things that are not arm64 specific
should better be split into a separate commit. For example I noticed
that you make changes to the EFI bootstrap code. I will need to test
this on ia64 hw for regressions. New arm64 stuff, however, can go into a
single PR.

Jakub

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to