On 05/21/2010 06:12 AM, Rick Flower wrote:
On Fri, 21 May 2010 05:56:13 +0200, Paolo Bonzini<[email protected]> wrote:
Any ideas on whether this was proper handling or not? I was hoping
it would return the entire string which is what I think it should
be doing based on reading the docs..
Looks like a better choice even if the docs said otherwise.
The only small problem is that an incomplete boundary string at the
end would of course be included in the return value.
Does that mean there's something wrong with the current
implementation of upToAll:?
After actually debugging it, the bug is in pipes. The following patch
fixes it, though I am committing another one that gets rid of the
"atEnd" instance variable completely.
diff --git a/kernel/FileDescr.st b/kernel/FileDescr.st
index 8f1d23f..54c29e2 100644
--- a/kernel/FileDescr.st
+++ b/kernel/FileDescr.st
@@ -740,7 +740,7 @@ do arbitrary processing on the files.'>
<category: 'initialize-release'>
self addToBeFinalized.
access isNil ifTrue: [access := 3].
- atEnd := false
+ atEnd := nil
]
readStream [
Paolo
_______________________________________________
help-smalltalk mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
