Seems like logical improvement to me, only not sure wether it would
break customized cms's. 

Can anybody shed some light on this?

-Ard

> Hi,
> 
> Another change ... ;-)
> 
> At the moment, custom workflow is copied after 
> cocoon:install, which is great for local cocoon:install 
> builds and for deployments. However, during development it's 
> common to use cocoon:deploy instead, and in this case the 
> custom workflow copy is missed. How about changing 
> cocoon:install to simply attainGoal, adding a cocoon:deploy 
> postGoal that does the same, like this:
> 
>   <!-- Copy workflow components into the target directory if 
> custom workflows exist -->
>   <postGoal name="cocoon:install">
>       <attainGoal name="workflowCopy"/>
>   </postGoal>
> 
>   <postGoal name="cocoon:deploy">
>       <attainGoal name="workflowCopy"/>
>   </postGoal>
> 
>   <goal name="workflowCopy">
>     <ant:copy 
> file="${maven.cocoon.dest.dir}/config/log4j.xml" todir="${ 
> maven.cocoon.dest.dir}/cocoon/WEB-INF/classes" />
>     <j:set var="workflowDirectory" value="${cms.workflow.dir}"/>
>     <j:set var="serverConfiguration" value="${context.getVariable('
> maven.cocoon.servermanager.configuration')}"/>
>     <j:if test="${not empty(workflowDirectory)}">
>       <u:file var="workflowDir" name="${cms.workflow.dir}"/>
>       <j:if test="${workflowDir.exists()}">
>         <!-- Build custom workflows first -->
>         <maven:reactor basedir="${cms.workflow.dir}" 
> includes="project.xml"
> goals="build"/>
>         <ant:copy
> todir="${maven.cocoon.home}/WEB-INF/configuration/projects/${s
> erverConfiguration}/workflows"
> filtering="off" flatten="true">
>           <fileset dir="${workflowDir}">
>             <include name="**/*.zip" />
>           </fileset>
>         </ant:copy>
>       </j:if>
>     </j:if>
>   </goal>
> 
> (I assume it's not possible to do <postGoal name="foo,bar">?)
> 
> 
> Andrew.
> --
> Sourcesense: Making sense of Open Source
> Tel: +44 (0)870 741 6658  Fax: +44 (0)700 598 1135
> Web: http://www.sourcesense.com/
> ********************************************
> Hippocms-dev: Hippo CMS development public mailinglist
> 
********************************************
Hippocms-dev: Hippo CMS development public mailinglist

Reply via email to