[
https://issues.apache.org/jira/browse/HIVE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650306#action_12650306
]
Pete Wyckoff commented on HIVE-73:
----------------------------------
overall looks good, but some comments on the code:
1. there's a lot of weird directories in some of the config/startup scripts.
/mnt/vol/hive, ...
2. why do you need the C++ headers for thrift here? without all of thrift,
they cannot compile/run anyway
3. for the get type when generating dynamic serde, do you not need to translate
types like int to i32?
4. many of the exceptions have no info other than the stack trace - i.e., you
don't instantiate them with a meaningful string.
5. are you sure all the fb303 functions you are using are in the current public
release of thrift?
> Thrift Server and Client for Hive
> ---------------------------------
>
> Key: HIVE-73
> URL: https://issues.apache.org/jira/browse/HIVE-73
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.20.0
> Reporter: Raghotham Murthy
> Assignee: Raghotham Murthy
> Fix For: 0.20.0
>
> Attachments: hive-73.1.patch, hive-73.2.patch, hive-73.3.txt,
> hive-73.4.txt, hive-73.5.txt
>
>
> Currently the hive cli directly calls the driver code. We need to be able to
> run a stand alone hive server that multiple clients can connect to. The hive
> server will allow clients to run queries as well as make meta data calls (by
> inheriting from the thrift metastore server)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
