[
https://issues.apache.org/jira/browse/HIVE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650812#action_12650812
]
Ashish Thusoo commented on HIVE-73:
-----------------------------------
Michi.. I think with the following code review encapsulates many of the
discussions.. once these are addressed we can move to commit this in...
This is from a combined code review with Namit, Ashish and Raghu...
Please use the functions in MetastoreUtils.java to create the thrift DDL from
tableDesc stored in fetchTask via that loadFileWork.
Rest of the comments are inlined.
Inline Comments
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:195 We
should avoid the copy here. It is better to accumulate only the necessary
number of rows and then pass that list out.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:134 Can you
make this a utility function.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:71 Can you
move this to HiveConf.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:85 Since
JDBC support multiple statements per session, we need to have a mapping from
session to statements and then from statement to driver.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:220 Can you
add javadocs.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:221 These
are not in the thrift interface?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:87 Session
state is not thread safe (it is a singleton), so this is blocked on the thread
safety JIRA
service/src/java/org/apache/hadoop/hive/service/HiveClient.java:41
javadocs.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:1869 Should
use tableDesc here.
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:73 javadocs..
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:85 javadocs..
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:73 javadocs
> Thrift Server and Client for Hive
> ---------------------------------
>
> Key: HIVE-73
> URL: https://issues.apache.org/jira/browse/HIVE-73
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.20.0
> Reporter: Raghotham Murthy
> Assignee: Raghotham Murthy
> Fix For: 0.20.0
>
> Attachments: hive-73.1.patch, hive-73.2.patch, hive-73.3.txt,
> hive-73.4.txt, hive-73.5.txt, hive-73.6.patch
>
>
> Currently the hive cli directly calls the driver code. We need to be able to
> run a stand alone hive server that multiple clients can connect to. The hive
> server will allow clients to run queries as well as make meta data calls (by
> inheriting from the thrift metastore server)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
