[
https://issues.apache.org/jira/browse/HIVE-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653543#action_12653543
]
Joydeep Sen Sarma commented on HIVE-107:
----------------------------------------
looks good:
- please return non-zero exit code if no matching service is found
- might want to make ANT_LIB overridable by env variable (but i guess this can
happen as part of the hwi jira as well)
Didn't understand why the there's a for loop in bin/hive. looks like we are
insisting that --service is the first argument (otherwise we break out) - so
could write it as a simple if .. then ..
we are missing tests for the actual cli script (all queries are launched
through Java apis) - that makes me a bit nervous (but don't want to saddle this
jira with more testing).
> Case structure for bin hive
> ---------------------------
>
> Key: HIVE-107
> URL: https://issues.apache.org/jira/browse/HIVE-107
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Server Infrastructure
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
> Attachments: HIVE-107-1.patch, HIVE-107.patch
>
>
> Hive Web Server Hive-30 and the Hive Thrift Server Hive-78 both are started
> with the bin/hive file. We should have a base bin/hive with case structure so
> add ons can patch from that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
