[ 
https://issues.apache.org/jira/browse/HIVE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joydeep Sen Sarma updated HIVE-453:
-----------------------------------

    Attachment: hive-453.patch.1

- the bulk of the changes are to not use the default filesystem object in many 
code paths and instead use the one derived from the path/conf.
- the FetchTask.java changes are mostly indentation changes
- can't think of how to add a test right now - in order to add a test - i need 
two functioning file systems - one the default one and the other for an 
external table. without a minimr cluster to run the tests - i don't have this 
available.
- there was a small bug in DDLTask - addPartition that i realized while testing 
that has also been fixed. partition directory creation should be done before 
comitting metastore transaction - otherwise the transaction can be committed 
without the DDL statement succeeding.



> external table metastore and execution codepaths use default FileSystem 
> object instead of using one derived from the supplied path
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-453
>                 URL: https://issues.apache.org/jira/browse/HIVE-453
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Joydeep Sen Sarma
>            Priority: Critical
>         Attachments: hive-453.patch.1
>
>
> with fs.default.name set to file:///:
> hive> create external table kvu(key int, val string) location 
> 's3n://data.s3ndemo.hive/kv1.txt'
> FAILED: Error in metadata: java.lang.IllegalArgumentException: Wrong FS: 
> s3n://data.s3ndemo.hive/kv1.txt, expected: file:///
> stack trace:
>         at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:322)
>         at 
> org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem
> .java:52)
>         at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.jav
> a:308)
>         at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.jav
> a:462)
>         at 
> org.apache.hadoop.hive.metastore.Warehouse.mkdirs(Warehouse.java:90)
>         at 
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_tabl
> e(HiveMetaStore.java:293)
>         at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(Hive
> MetaStoreClient.java:252)
>         at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:256)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to