[ 
https://issues.apache.org/jira/browse/HIVE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704734#action_12704734
 ] 

Prasad Chakka commented on HIVE-453:
------------------------------------

create table part leaves the directory intact even if the transaction fails. i 
don't remember writing it that way but we should change that to create 
directory after the transaction has been committed. I don't think hive 
execution complains that directory doesn't exist.

the drop table & drop partition try to delete after the transaction is 
committed only because we don't want to delete the data without deleting 
metadata.

but, as you say we could try to drop the table/partitions directory if the 
transaction fails. then it should be fine.

> external table metastore and execution codepaths use default FileSystem 
> object instead of using one derived from the supplied path
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-453
>                 URL: https://issues.apache.org/jira/browse/HIVE-453
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Joydeep Sen Sarma
>            Priority: Critical
>         Attachments: hive-453.patch.1
>
>
> with fs.default.name set to file:///:
> hive> create external table kvu(key int, val string) location 
> 's3n://data.s3ndemo.hive/kv1.txt'
> FAILED: Error in metadata: java.lang.IllegalArgumentException: Wrong FS: 
> s3n://data.s3ndemo.hive/kv1.txt, expected: file:///
> stack trace:
>         at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:322)
>         at 
> org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem
> .java:52)
>         at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.jav
> a:308)
>         at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.jav
> a:462)
>         at 
> org.apache.hadoop.hive.metastore.Warehouse.mkdirs(Warehouse.java:90)
>         at 
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_tabl
> e(HiveMetaStore.java:293)
>         at 
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.createTable(Hive
> MetaStoreClient.java:252)
>         at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:256)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to