[
https://issues.apache.org/jira/browse/HIVE-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869224#action_12869224
]
Ning Zhang commented on HIVE-1348:
----------------------------------
Looks good in general. A few questions:
1) what is the reason to change ExecMapperContext to ExecMapperLocalContext?
Is the former only used in MapJoin?
2) ExecMapper.memoryMXBean is made a public static member and it is only used
in ExecMapperLocalContext. Is it really needed to report the memory usage
there? If not necessary we can keep it as private.
3) Do you need to pass ExecMapper instance to ExecMapperLocalContext? It seems
it is only needed for setting the abort status. Instead of doing that, we
probably should throw an exception in processMapLocalWork and the upper stream
operators and eventually ExecMapper will catch that and set the abort due to
the exceptions.
> Moving inputFileChanged() from ExecMapper to where it is needed
> ---------------------------------------------------------------
>
> Key: HIVE-1348
> URL: https://issues.apache.org/jira/browse/HIVE-1348
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Ning Zhang
> Assignee: He Yongqiang
> Attachments: hive-1348.1.patch
>
>
> inputFileChanged() is only needed for Bucketed sort merge map join. It should
> not be put in ExecMapper.map() where all code paths will hit this function.
> This function is quite expensive since JobConf look up is a hash table look
> up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
