[
https://issues.apache.org/jira/browse/HIVE-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869289#action_12869289
]
Ning Zhang commented on HIVE-1348:
----------------------------------
some details:
1) SMBMapJoinOperator and ExecMapperContext: why not just call the function
inputFileChanged() rather than maintaining another variable with the same name
inputFileChanged? There is not benefit in doing that and only make it more
complicated.
2) ExecMapper:72, execLocalContext --> execContext, variable name is not
consistent.
3) MapJoin:163-167: won't these lines change the semantics of what the mapjoin
operator did previously?
> Moving inputFileChanged() from ExecMapper to where it is needed
> ---------------------------------------------------------------
>
> Key: HIVE-1348
> URL: https://issues.apache.org/jira/browse/HIVE-1348
> Project: Hadoop Hive
> Issue Type: Improvement
> Reporter: Ning Zhang
> Assignee: He Yongqiang
> Attachments: hive-1348.1.patch, hive-1348.2.patch
>
>
> inputFileChanged() is only needed for Bucketed sort merge map join. It should
> not be put in ExecMapper.map() where all code paths will hit this function.
> This function is quite expensive since JobConf look up is a hash table look
> up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
