[ 
https://issues.apache.org/jira/browse/HIVE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870789#action_12870789
 ] 

Namit Jain commented on HIVE-287:
---------------------------------

Overall looks good, some minor comments:

1. This should be independent of COUNT - so, all basically all aggregation 
functions should be supported with DISTINCT.
    For eg: select avg(distinct c1,c2) from T

 and so on.

2. It would be a good idea to maintain some compatibility for the existing 
interface - so, can we add another method to UDAFResolver, which
    has the new API - and a common class which invokes the default 
implementation, that would be better.

3. Follows from 1 - more tests are needed

> count distinct on multiple columns does not work
> ------------------------------------------------
>
>                 Key: HIVE-287
>                 URL: https://issues.apache.org/jira/browse/HIVE-287
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Arvind Prabhakar
>             Fix For: 0.6.0
>
>         Attachments: HIVE-287-1.patch
>
>
> The following query does not work:
> select count(distinct col1, col2) from Tbl

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to