[ 
https://issues.apache.org/jira/browse/HIVE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871310#action_12871310
 ] 

Namit Jain commented on HIVE-287:
---------------------------------


I am sorry about 1 and 3 - you can ignore those.



2. It would be a good idea to maintain some compatibility for the existing 
interface - so, can we add another method to UDAFResolver, which has the new 
API - and a common class which invokes the default implementation, that would 
be better.

Here is what I understand your suggestion as: Add a new method to 
GenericUDAFResolver interface maintaining the old method. Create an abstract 
base class that implements the new interface method and invokes the old method 
by dropping isDistinct/isAllColumn arguments. Extend the current resolvers to 
override this method. Will this address your concern? If not, can you provide a 
concrete example.


-- yes





> count distinct on multiple columns does not work
> ------------------------------------------------
>
>                 Key: HIVE-287
>                 URL: https://issues.apache.org/jira/browse/HIVE-287
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Arvind Prabhakar
>             Fix For: 0.6.0
>
>         Attachments: HIVE-287-1.patch
>
>
> The following query does not work:
> select count(distinct col1, col2) from Tbl

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to