[ 
https://issues.apache.org/jira/browse/HIVE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882792#action_12882792
 ] 

John Sichi commented on HIVE-287:
---------------------------------

Sorry, my commit for HIVE-1387 just introduced a new conflict, so one more 
rebase is required.

I still don't think that we should allow anything other than COUNT(*) in the 
parser.  SUM(*) should be disallowed, as should COUNT(DISTINCT *), as should 
MY_UDF(*).  They are non-standard, and I think they would just cause confusion 
since COUNT(*) ignores the column values rather than doing anything with them.  
Together with preventing these, add negative tests to verify that they are 
rejected.

Given that, we can get rid of the isAllColumns info.

Also, can you add an EXPLAIN for the COUNT(*) query in the test?

After that, I think we'll be good to go.


> count distinct on multiple columns does not work
> ------------------------------------------------
>
>                 Key: HIVE-287
>                 URL: https://issues.apache.org/jira/browse/HIVE-287
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Arvind Prabhakar
>         Attachments: HIVE-287-1.patch, HIVE-287-2.patch, HIVE-287-3.patch, 
> HIVE-287-4.patch
>
>
> The following query does not work:
> select count(distinct col1, col2) from Tbl

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to