[
https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909046#action_12909046
] HBase Review Board commented on HIVE-1625: ------------------------------------------ Message from: "John Sichi" <jsi...@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/827/ ----------------------------------------------------------- Review request for Hive Developers. Summary ------- review by JVS This addresses bug HIVE-1625. http://issues.apache.org/jira/browse/HIVE-1625 Diffs ----- http://svn.apache.org/repos/asf/hadoop/hive/trunk/data/files/pstmt.txt PRE-CREATION http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveParameterValue.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java 995557 http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/MockHiveConnection.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/MockHivePreparedStatement.java PRE-CREATION http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 995557 Diff: http://review.cloudera.org/r/827/diff Testing ------- Thanks, John > Added implementation to HivePreparedStatement, HiveBaseResultSet and > HiveQueryResultSet. > ---------------------------------------------------------------------------------------- > > Key: HIVE-1625 > URL: https://issues.apache.org/jira/browse/HIVE-1625 > Project: Hadoop Hive > Issue Type: Improvement > Reporter: Sean Flatley > Assignee: Sean Flatley > Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log > > > We implemented several of the HivePreparedStatement set methods, such as > setString(int, String) and the means to substitute place holders in the SQL > with the values set. > HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() > could be implemented. > See attached change log for details. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
