[ 
https://issues.apache.org/jira/browse/HIVE-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910263#action_12910263
 ] 

HBase Review Board commented on HIVE-1625:
------------------------------------------

Message from: "John Sichi" <jsi...@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/827/#review1246
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveParameterValue.java
<http://review.cloudera.org/r/827/#comment4208>

    These data members should be private.



http://svn.apache.org/repos/asf/hadoop/hive/trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java
<http://review.cloudera.org/r/827/#comment4209>

    What is the purpose of typeMatches?


- John





> Added implementation to HivePreparedStatement, HiveBaseResultSet and 
> HiveQueryResultSet.
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-1625
>                 URL: https://issues.apache.org/jira/browse/HIVE-1625
>             Project: Hadoop Hive
>          Issue Type: Improvement
>            Reporter: Sean Flatley
>            Assignee: Sean Flatley
>         Attachments: changelog.txt, HIVE-1625.patch, testJdbcDriver.log
>
>
> We implemented several of the HivePreparedStatement set methods, such as 
> setString(int, String) and the means to substitute place holders in the SQL 
> with the values set.  
> HiveQueryResultSet and HiveBaseResultSet were enhanced so that getStatement() 
> could be implemented.
> See attached change log for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to