I agree 100%. There are now two methods that provide the same functionality
(keepRunning() and isRunning()). I've deprecated the former and added some
javadoc to explain the change.
Certainly prevailing conventions would dictate that the method be named
isRunning(), but I'm betting that the old method predates that convention.
:)
James
On Tue, May 19, 2009 at 9:39 AM, Erik Gfesser <[email protected]> wrote:
> Thanks Peter. My time is a bit short at the moment to look at the source
> code, but solely looking at the names of the methods, it seems that
> "keepRunning" would indicate whether the server _should_ continue to run
> rather than "isRunning" which seems to answer the boolean question as to
> whether the server is _actually_ still running. If the same question is
> being answered by both methods (i.e. is the server running?), perhaps the
> name of the "keepRunning" variable should be changed to provide
> clarification to users of HAPI.
>
>
> Erik
>
> *Peter Gershkovich <[email protected]>* wrote:
>
> I added the following method to the HL7Server class.
>
> public boolean isRunning() {
> return keepRunning;
> }
>
> If I am not mistaken it reliably tells me if the servers is running or
> not.
> In our case when the application is initiated a SimpleServer object is
> saved to the application context. Now at any point in time a client may
> verify if it is running or not and start and stop it without guessing its
> state.
>
> Please let me know if my assumptions are accurate and if so would it be
> possible to add this change to the source code.
>
> Thanks,
> Peter
>
>
> On May 19, 2009, at 8:16 AM, Erik Gfesser wrote:
>
> Asanka,
>
> Please see the attached reply I recently provided to Peter Gershkovich. No,
> HAPI does not provide JMX support at this point in time. I needed to provide
> custom development in order to incorporate JMX, but it was worth the effort
> to incorporate this functionality; the administrators of the new application
> I built were happy with the results due to its ease of use and its provision
> of an abstraction over technology that was new to them.
>
> Erik
>
>
> *Erik Gfesser <[email protected]>* wrote:
>
> Peter,
>
> My personal recommendation to you is usage of JMX to start and stop
> SimpleServer. I architected and developed an HL7 communications component
> using HAPI for a recent client, and this solution worked extremely well for
> us. Usage of JMX technology not only will provide a built-in browser
> interface that you do not need to develop, but will also help enable easy
> detection of whether the server is up and running. Are you building this
> solution as an academic exercise or for real-world deployment? I'm
> interested in hearing about your work.
>
> Erik
>
> *Peter Gershkovich <[email protected]>* wrote:
>
> I am writing a web interface that would allow users to start/stop
> SimpleServer.
>
> Is there a way to determine the state of that server. E.g. there are
> star() and stop() methods in SimpleServer class but there is no
> isRunning().
>
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables
> unlimited royalty-free distribution of the report engine
> for externally facing server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Hl7api-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
>
>
>
>
>
>
>
>
> *Asanka Abeysinghe <[email protected]>* wrote:
>
> Getting JMX support implemented to the server is the ideal solution, do
> we already have JMX support for HAPI ? (Sorry I'm new to the library).
> If you want to use a WEB interface why not use Monit, that will do all
> the operations you required and provide a nice UI.
> > - Asanka
> > Peter Gershkovich wrote:
> >> I am writing a web interface that would allow users to start/stop
> >> SimpleServer.
> >>
> >> Is there a way to determine the state of that server. E.g. there are
> >> star() and stop() methods in SimpleServer class but there is no
> >> isRunning().
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> ------------------------------------------------------------------------------
>
> >>
> >> Crystal Reports - New Free Runtime and 30 Day Trial
> >> Check out the new simplified licensing option that enables unlimited
> >> royalty-free distribution of the report engine for externally facing
> >> server and web deployment. http://p.sf.net/sfu/businessobjects
> >> _______________________________________________
> >> Hl7api-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
> >>
> >>
> >
> >
>
>
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables
> unlimited royalty-free distribution of the report engine
> for externally facing server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Hl7api-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
>
>
>
>
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables
> unlimited royalty-free distribution of the report engine
> for externally facing server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Hl7api-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
>
>
>
>
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables
> unlimited royalty-free distribution of the report engine
> for externally facing server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Hl7api-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/hl7api-devel
>
>
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Hl7api-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hl7api-devel
