+1 for isRunning(),
- Asanka

James Agnew wrote:
I agree 100%. There are now two methods that provide the same functionality (keepRunning() and isRunning()). I've deprecated the former and added some javadoc to explain the change.

Certainly prevailing conventions would dictate that the method be named isRunning(), but I'm betting that the old method predates that convention. :)

James

On Tue, May 19, 2009 at 9:39 AM, Erik Gfesser <[email protected]> wrote:
Thanks Peter. My time is a bit short at the moment to look at the source code, but solely looking at the names of the methods, it seems that "keepRunning" would indicate whether the server _should_ continue to run rather than "isRunning" which seems to answer the boolean question as to whether the server is _actually_ still running. If the same question is being answered by both methods (i.e. is the server running?), perhaps the name of the "keepRunning" variable should be changed to provide clarification to users of HAPI.


Erik

P

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
_______________________________________________
Hl7api-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hl7api-devel

Reply via email to