Hi John,

I'm seeing failures-to-startup on my srcds instances with the new update,
and it looks it's due to some new/modified code in dedicated_srv.so that's
causing infinite recursion on attempts to open and write to the console
log, evidently terminating in a stack overflow.

I haven't had a chance to bindiff the binaries across versions just yet,
but an initial peek leads me to believe that the culprit is some new
warning code in CBaseFileSystem::OpenForWrite that wasn't there before.

Running srcds causes hundreds of lines of ">>> [srcds_path]/tf/console.log
- Open for write." to be written to the terminal before it ultimately
crashes.

Here's a stack trace:
#0  0x00000000f7d08fee _SpewMessage(SpewType_t, char const*, int, Color
const*, char const*, char*)         (bin/libtier0_srv.so)
#1  0x00000000f7d0964c Warning
                                 (bin/libtier0_srv.so)
#2  0x00000000f733f801 CBaseFileSystem::Warning(FileWarningLevel_t, char
const*, ...) const                 (bin/dedicated_srv.so)
#3  0x00000000f734b604 CBaseFileSystem::OpenForWrite(char const*, char
const*, char const*)                 (bin/dedicated_srv.so)
#4  0x00000000f734b9d8 CBaseFileSystem::OpenEx(char const*, char const*,
unsigned int, char const*, char**) (bin/dedicated_srv.so)
#5  0x00000000f733cd49 CBaseFileSystem::Open(char const*, char const*, char
const*)                         (bin/dedicated_srv.so)
#6  0x00000000f736ba59 CTextConsoleUnix::Print(char*)
                                (bin/dedicated_srv.so)
#7  0x00000000f736da49 CSys::Printf(char const*, ...)
                                (bin/dedicated_srv.so)
#8  0x00000000f736ca7c DedicatedSpewOutputFunc(SpewType_t, char const*)
                                (bin/dedicated_srv.so)
#9  0x00000000f7d090ab _SpewMessage(SpewType_t, char const*, int, Color
const*, char const*, char*)         (bin/libtier0_srv.so)
#10 0x00000000f7d0964c Warning
                                 (bin/libtier0_srv.so)
#11 0x00000000f733f801 CBaseFileSystem::Warning(FileWarningLevel_t, char
const*, ...) const                 (bin/dedicated_srv.so)
#12 0x00000000f734b604 CBaseFileSystem::OpenForWrite(char const*, char
const*, char const*)                 (bin/dedicated_srv.so)
#13 0x00000000f734b9d8 CBaseFileSystem::OpenEx(char const*, char const*,
unsigned int, char const*, char**) (bin/dedicated_srv.so)
#14 0x00000000f733cd49 CBaseFileSystem::Open(char const*, char const*, char
const*)                         (bin/dedicated_srv.so)
#15 0x00000000f736ba59 CTextConsoleUnix::Print(char*)
                                (bin/dedicated_srv.so)
#16 0x00000000f736da49 CSys::Printf(char const*, ...)
                                (bin/dedicated_srv.so)
#17 0x00000000f736ca7c DedicatedSpewOutputFunc(SpewType_t, char const*)
                                (bin/dedicated_srv.so)
#18 0x00000000f7d090ab _SpewMessage(SpewType_t, char const*, int, Color
const*, char const*, char*)         (bin/libtier0_srv.so)
<...>

I'll investigate this further.

Justin (sigsegv)

On Mon, Sep 23, 2019 at 2:34 PM John Schoenick <jo...@valvesoftware.com>
wrote:

> We've released a mandatory update for Team Fortress 2. The notes for the
> update are below. The new version is 5368522.
>
> - John
>
> ------------------------------------------------------------
>
> - Fixed the Iron Lung hiding the Engineer's helmet
> - Fixed Scottish Resistance stickies not always being visible through walls
> - Fixed the Festive Sapper not playing a timer sound while attached to
> buildings
> - Updated/Added some tournament medals
> - Updated the Bottle Cap and the Shutterbug cosmetic items to fix styles
> that were missed when the items were originally added
> - Updated Twitch API to the current version
> - Updated the localization files
>
> _______________________________________________
> To unsubscribe, edit your list preferences, or view the list archives,
> please visit:
> https://list.valvesoftware.com/
_______________________________________________
To unsubscribe, edit your list preferences, or view the list archives,
please visit:
https://list.valvesoftware.com/

Reply via email to