Excerpts from leon breedt's mail of 30 Jul 2005 (EDT):
> Okay, I've reworked my patch a little, not quite sure if the
> indentation conforms to the desired, but I think so.

I like this patch. I have it applied to my blog and it works perfectly.
Nice work.

> I've broken the comment template into two (the actual comment list,
> and the entry form).

I think this separation is good. I put this in my entry erb:

  <% if entry and not defined? entries %>
    <h3>Comments</h3>
    <+ entry_comment +>
    <% if entry.created < (Time.now - (14 * 24 * 60 * 60)) %>
      <p>This entry has been archived and comments are no longer accepted.</p>
    <% else %>
      <+ entry_comment_form +>
    <% end %>
    <+ entry_trackback +>
  <% end %>

... which drops the comment form for entries older than two weeks. (Of
course they can still technically be added, but it's not as obvious.)

> The comment type has pretty much the same field names as those used of
> Entry (so your existing templates shouldn't break), with the addition
> of "url", "email" and "ipaddress".

Duck-typing at its finest. Mixing old and new comments works perfectly
for me.

I'd like to commit this patch. Anyone else want to test? Any comments?

-- 
William <[EMAIL PROTECTED]>
_______________________________________________
Hobix-is-the-way mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/hobix-is-the-way

Reply via email to