On Sat, 2006-09-30 at 09:12 +0200, Paul van Tilburg wrote: > * The title of an entry is not processed by RedCloth or something > else. > If the title contains for example &, it will lead to invalid HTML.
That's really an issue for the templates. We need to provide an 'h'
method or similar to the way Rails does for views, to make it easy to
html-quote non-formatted strings.
> * I have found some small issues with the comments plugin since I
> keep being
> comment-spammed a lot:
> - There is no spam protection, RedHanded seems to have some. I
> think
> we should release with some protection out of the box.
The main thing is I don't feel comfortable implementing that myself, as
I don't use hobix comments at all (yet).
Part of me is inclined to release 0.5 without spam protection just so
someone using the feature is motivated to send in a patch and we can do
an 0.6 quick on the heels. :)
> - Maybe it is wise to postprocess the comments with RedCloth in
> filter_html
> mode. I get a lot of spams containing something like:
>
> This is a foo you should <a href="bla foo bar.. more stuff
>
> and then leaves the quote open so my page looks completely
> garbled.
Hmm, yes, that sounds like a good idea. Do comments get their own entry
class? If so, we should probably look into a general approach for
turning filter_html on/off for a particular entry class.
> - The preview button is not working. I get a JavaScript error:
>
> [JavaScript Error: "invalid flag after regular expression" {file:
>
> "http://paul.luon.net/journal/life/AnkorauxUnuEsperantpostajxo#comments";
> line: 1 column: 18 source: "new Ajax.Request(
> /journal/control/preview, {parameters:
> Form.serialize('userComment'), onComplete: function(req) {
> $('textilePreview').innerHTML = req.responseText }})"}]
>
> "new Ajax.Request( /journal/control/preview, {parameters:
> Form.serialize('userComment'), onComplete: function(req) {
> $('textilePreview').innerHTML = req.responseText }})"
>
> Line 1, Column 18, File "AnkorauxUnuEsperantpostajxo#comments" in
> "http://paul.luon.net/journal/life";
I think I've got this one more or less fixed. svn up and let me know.
> > If not, I'll look at doing the 0.5 release next week.
>
> That would be great :)
Well... sounds like we've still got some work to do.
-mental
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Hobix-is-the-way mailing list [email protected] http://rubyforge.org/mailman/listinfo/hobix-is-the-way
