On Sun, Oct 01, 2006 at 04:31:23PM -0400, MenTaLguY wrote:
> On Sat, 2006-09-30 at 09:12 +0200, Paul van Tilburg wrote:
> >  * The title of an entry is not processed by RedCloth or something
> > else.
> >    If the title contains for example &, it will lead to invalid HTML.
> 
> That's really an issue for the templates.  We need to provide an 'h'
> method or similar to the way Rails does for views, to make it easy to
> html-quote non-formatted strings.

Ok, this can be noted as an ToDo item.

Which reminds me, since all _why's projects, including this one is now
fully hosted on code.whytheluckystiff.net, do we file bugreports/tickets
in the built-in Trac or still in the RubyForge project.  I would much
prefer the first option!  Even more so, if why can add the hook to be
able to close tickets from svn commit logs (such as:  "Added new method
for foo (fixes #21)").

> 
> >  * I have found some small issues with the comments plugin since I
> >    keep being comment-spammed a lot:
> >    - There is no spam protection, RedHanded seems to have some. I
> >      think we should release with some protection out of the box.
> 
> The main thing is I don't feel comfortable implementing that myself, as
> I don't use hobix comments at all (yet).

I am using it also for the sake of trying it out.  So far it works well,
except for one page that seems to be very popular with comment spammers.
That page is almost made unrenderable by the comments within two days,
I hadn't expected that.

> Part of me is inclined to release 0.5 without spam protection just so
> someone using the feature is motivated to send in a patch and we can do
> an 0.6 quick on the heels. :)

;) I think we can.  I should have some more time later on to work on the
plugins.

> >    - Maybe it is wise to postprocess the comments with RedCloth in
> >      filter_html mode. I get a lot of spams containing something like:
> > 
> >      This is a foo you should <a href="bla foo bar.. more stuff
> > 
> >      and then leaves the quote open so my page looks completely
> > garbled.
> 
> Hmm, yes, that sounds like a good idea.  Do comments get their own entry
> class?  If so, we should probably look into a general approach for
> turning filter_html on/off for a particular entry class.

Yes: class Comment < BaseContent; [...]
        _ :content,   :edit_as => :textarea, :search => :fulltext, 
:text_processor => true

> >    - The preview button is not working. I get a JavaScript error:
> > 
> >      [JavaScript Error: "invalid flag after regular expression"
> >         {file: [...]
> > 
> I think I've got this one more or less fixed.  svn up and let me know.

I'll try it out soon, will reply later.

> > > If not, I'll look at doing the 0.5 release next week.
> > 
> > That would be great :)
> 
> Well... sounds like we've still got some work to do.

Well, I think it's not that much.  We can leave the comments support
fixes for now and denote that it is preliminary in the ChangeLog.

Paul

-- 
Student @ Eindhoven                         | email: [EMAIL PROTECTED]
University of Technology, The Netherlands   | JID: [EMAIL PROTECTED]
>>> Using the Power of Debian GNU/Linux <<< | GnuPG key ID: 0x50064181

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Hobix-is-the-way mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/hobix-is-the-way

Reply via email to