> Please apply the following patch, it is required for proper 
> compilation under gcc 4.1.  Gcc 4.1 will see wide use very 
> soon, in fact some arches require it, and Debian is seriously 
> considering switching to gcc 4.1 for the next stable version.
> 
> Without this patch, hpijs has to be compiled using 
> --no-strict-aliasing.

Thanks for the patch, it looks valid for gcc compile issues.
 
> BTW: the hunk that applies to prnt/hpijs/hpijs.cpp illustrates
> beautifully(?!) the utter lack of untrusted input validation 
> one can find in hpijs.  I don't have time to add paranoia to 
> hpijs, but please take this as a request that someone 
> dedicate paid time to fix that mess (and the big mess with 
> types and huge amount of typecasts, often dangerous and prone 
> to breakage on various arches).

The reason we do not need parameter checking here in hpijs is because a
invalid print mode (ie: Quality, MediaType, ColorMode, ...) will default
to a valid print mode. The goal is to always print if possible but with
a warning for invalid input.

-dave


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
HPLIP-Devel mailing list
HPLIP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hplip-devel

Reply via email to