On Thu, 11 May 2006, Suffield, David wrote: > > Without this patch, hpijs has to be compiled using > > --no-strict-aliasing. > > Thanks for the patch, it looks valid for gcc compile issues.
It was validated using gcc 4.1 (and gcc 4.1 was the one who complained in the first place), so yes, it is valid for gcc compile issues :-) It is also cleaner C++ code too, which is always a plus. > > BTW: the hunk that applies to prnt/hpijs/hpijs.cpp illustrates > > beautifully(?!) the utter lack of untrusted input validation [...] > The reason we do not need parameter checking here in hpijs is because a > invalid print mode (ie: Quality, MediaType, ColorMode, ...) will default > to a valid print mode. The goal is to always print if possible but with > a warning for invalid input. That's quite nice to know. It eases my mind to know that such parameters are validated (or at least gracefully dealt with when out-of-bonds) elsewhere in the code. Still, the plea for someone cleaning up the typecast mess in hpijs holds, the ammount of signed/unsigned bombs and type size bombs that could be hidden by the indiscriminate typecasts hpijs seems to have can't be healthy... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ HPLIP-Devel mailing list HPLIP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hplip-devel
