DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38624>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38624 ------- Additional Comments From [EMAIL PROTECTED] 2006-02-17 20:10 ------- Hi Oleg, I think I got the drift of your changes. I like the removal of the extra params from the SimpleDispatcher in favor of the params stored anyway in the HttpRequestExecutor/AsyncHttpProcessor. You missed a few @param params tags there, I get three javadoc warnings in async: AbstractHttpDispatcher.java:136 AsyncHttpProcessor.java:90 SimpleHttpDispatcher.java:130 The renaming of the methods in HRX is fine by me. I intentionally chose other terms than "send" and "receive" because there are already too many ways of sending for my liking: with or without preprocessing, sending on a connection or just queuing a request. Anyway, I don't mind. You should remove the method name comment I had put at the end of what is now receiveResponse. I'm less comfortable with the send method having no flag to disable the expect-continue handshake. The check you put into AHP.transmitRequest makes assumptions about the implementation of HRX.sendRequest by replicating the check for expect-continue. It's not likely to cause a problem though, so I can live with it. Could you update the JavaDoc of HRX.sendRequest to explicitly state that the method will not attempt to receive anything unless it has to handle an expect-continue handshake? That is an important precondition for using it asynchronously, and it should be documented there. I had it mentioned in the JavaDoc for the parameter you removed. Removing the 'terminal' flag from HRX.receiveResponse kills any ideas I was pondering about how to make 1xx responses accessible to applications that might need them. There's plenty of other stuff to do that is more important, so I can live with that too. For the time being :-) cheers, Roland -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
