DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38624>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38624 ------- Additional Comments From [EMAIL PROTECTED] 2006-02-17 23:00 ------- (In reply to comment #7) Roland, I checked in the patch. Please review the code once more and submit any corrective patches you deem necessary. I am leaving the ticket open for the time being. My primary and foremost concern was that too many http-async concerns were carried over into HttpRequestExecutor. Sometimes, code duplication is a lesser evil than inheritance abuse and tight coupling of super and sub classes > > The renaming of the methods in HRX is fine by me. I intentionally > chose other terms than "send" and "receive" because there are > already too many ways of sending for my liking: with or without > preprocessing, sending on a connection or just queuing a request. > Anyway, I don't mind. You should remove the method name comment > I had put at the end of what is now receiveResponse. > I do not mind calling those methods differently. I just did not like the fact that some methods in sub class had a different parameter signature as methods in the super class with the same name > > Removing the 'terminal' flag from HRX.receiveResponse kills any > ideas I was pondering about how to make 1xx responses accessible > to applications that might need them. There's plenty of other > stuff to do that is more important, so I can live with that too. > For the time being :-) > Any application that needs access to 1xx status codes should use HttpConnection classes directly. HttpRequestExecutor cannot be everything to everyone Oleg PS: have you sent in your CLA? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
