On Thu, 2013-04-25 at 15:26 +0100, sebb wrote: > On 25 April 2013 14:45, Oleg Kalnichevski <ol...@apache.org> wrote: > > > On Thu, 2013-04-25 at 13:28 +0100, sebb wrote: > > > On 25 April 2013 12:26, Oleg Kalnichevski <ol...@apache.org> wrote: > > > > > > > On Thu, 2013-04-25 at 12:13 +0100, sebb wrote: > > > > > On 25 April 2013 12:03, Oleg Kalnichevski <ol...@apache.org> wrote: > > > > > > > > > > > On Thu, 2013-04-25 at 11:40 +0100, sebb wrote: > > > > > > > On 25 April 2013 11:22, Oleg Kalnichevski <ol...@apache.org> > > wrote: > > > > > > > > > > > > > > > On Wed, 2013-04-24 at 21:34 +0200, Philippe Mouawad wrote: > > > > > > > > > Sorry Oleg, I mixed up my question. > > > > > > > > > > > > > > > > > > So does HTTPCLIENT-1340 affect 4.2.3 version of HttpClient ? > > I am > > > > > > > > confused > > > > > > > > > about JIRA indicating it affects 4.2.3 BETA which suggest > > 4.2.3 > > > > could > > > > > > > > also > > > > > > > > > be concerned. > > > > > > > > > > > > > > > > > > > > > > > > > The bug affects ALL versions of 4.2.x prior to 4.2.5 (including > > > > 4.2.3). > > > > > > > > It also affects deprecated code in 4.3 branch. > > > > > > > > > > > > > > > > > > > > > > > Are there any plans to fix the deprecated code? > > > > > > > I'm not saying we should, just wondering how to make the JIRA > > > > clearer. > > > > > > > > > > > > > > > > > > > Sebastian > > > > > > I did already back-port the fix to deprecated classes in 4.3 and > > > > clearly > > > > > > > > > > > > > > > > But you also wrote: > > > > > > > > > > "It also affects deprecated code in 4.3 branch." > > > > > > > > > > I cannot reconcile those two statements. > > > > > > > > > > > > > > > > > > My English certainly has its limits but I fail to see a contradiction > > in > > > > those statements. > > > > > > > > > [It's probably more a question of context/perspective than English, > > because > > > yours is better than quite a few native speakers! > > > I don't always immediately understand US English, because they ascribe > > > different meanings to some English words, e.g. pavement, table(verb)] > > > > > > I took the first sentence to mean that the deprecated classes in 4.3 have > > > been fixed (i.e. are not affected) > > > I took the second to mean that the deprecated code in 4.3 branch (i.e. > > > trunk) is still affected. > > > > > > That is the contradiction I could not understand, see further below. > > > > > > The bug affects all releases from the 4.3 branch > > > > (which is currently trunk). The bug has been fixed in SVN trunk by > > > > back-porting the fix from the 4.2 branch. > > > > > > > > > > > So I take it that the bug affects all existing 4.3 releases, but has > > since > > > been fixed in trunk and therefore the bug will be fixed in the next 4.3 > > > release? > > > Is that correct? > > > > > > > Yes and no. New connection management code in 4.3 has been pretty much > > completely rewritten and has diverged significantly from the original > > code affected by the bug. It never exhibited the said defect to start > > with. Users of 4.3 who migrated off the deprecated API have nothing to > > worry about. > > > > > So does the deprecated code that remains in 4.3 still suffer from the bug? > >
No, it does not. I back-ported the fix from 4.2 to 4.3 (deprecated code only). Oleg > > > If so, the Jira can be update at some point to add a 4.3 release to the > > Fix. > > > > > > > If all it takes is changing some attributes on the JIRA ticket by all of > > means go ahead and do what you deem appropriate. > > > > > I need to think on that further. > > > > Oleg > > > > > Oleg > > > > > > > > > > > > > > stated that fact in JIRA comments. This is also the reason why I > > kept > > > > > > 4.3-beta1 listed among affected versions > > > > > > > > > > > > > > > > > But is 4.3-beta1 not superseded by 4.3 ? > > > > > If so, can we just mark it fixed in 4.3? > > > > > > > > > > Oleg > > > > > > > > > > > > > It looks odd if one of the affected versions is never apparently > > > > fixed. > > > > > > > > > > > > > > I'll add a comment to the issue, but it would be useful to be > > able to > > > > > > tidy > > > > > > > up the Fix version at some point. > > > > > > > If dep. code is not to be fixed, perhaps we could add a dummy > > > > version 4.3 > > > > > > > (deprecated code) ? > > > > > > > > > > > > > > Oleg > > > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > Regards > > > > > > > > > Philippe > > > > > > > > > > > > > > > > > > On Wed, Apr 24, 2013 at 4:00 PM, Oleg Kalnichevski < > > > > ol...@apache.org > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > On Wed, 2013-04-24 at 13:02 +0100, sebb wrote: > > > > > > > > > > > On 24 April 2013 12:18, Oleg Kalnichevski < > > ol...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2013-04-24 at 12:58 +0200, Philippe Mouawad > > wrote: > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > Just a clarification, does > > > > > > > > > > > > > HTTPCLIENT-1340< > > > > > > > > > > https://issues.apache.org/jira/browse/HTTPCLIENT-1340 > > > > > > > > > > > > >affects > > > > > > > > > > > > > 4.2.3 ? > > > > > > > > > > > > > JIRA indicates 4.2.3 Beta. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The bug affects all versions of 4.2.x prior to 4.2.5. > > The > > > > bug > > > > > > does > > > > > > > > not > > > > > > > > > > > > affect 4.3.x series. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > However the JIRA says: > > > > > > > > > > > > > > > > > > > > > > *Affects Version/s:* 4.2.4, 4.3 Beta1 > > > > > > > > > > > > > > > > > > > > > > Is that wrong? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > It depends how you look at it. The bug does not affect new > > > > code in > > > > > > 4.3 > > > > > > > > > > but it does affect old deprecated code. > > > > > > > > > > > > > > > > > > > > Oleg > > > > > > > > > > > > > > > > > > > > > Oleg > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > Regards > > > > > > > > > > > > > Philippe > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Apr 24, 2013 at 12:41 PM, Oleg Kalnichevski < > > > > > > > > > > ol...@apache.org > > > > > > > > > > > > >wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > The HttpComponents project is pleased to announce > > > > 4.2.5 GA > > > > > > > > release > > > > > > > > > > of > > > > > > > > > > > > > > Apache HttpClient. This is a bug fix release that > > > > > > addresses a > > > > > > > > > > number of > > > > > > > > > > > > > > issues reported since release 4.2.4 including a > > major > > > > bug > > > > > > that > > > > > > > > can > > > > > > > > > > lead > > > > > > > > > > > > > > to re-use of persistent connections in a > > inconsistent > > > > > > state. > > > > > > > > > > > > > > > > > > > > > > > > > > > > All users of HttpClient 4.2 are strongly advised to > > > > > > upgrade. > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------- > > > > > > > > > > > > > > Download - > > > > > > > > > > > > > > <http://hc.apache.org/downloads.cgi> > > > > > > > > > > > > > > > > > > > > > > > > > > > > Release notes - > > > > > > > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://www.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES-4.2.x.txt > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > HttpComponents site - > > > > > > > > > > > > > > <http://hc.apache.org/> > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------- > > > > > > > > > > > > > > > > > > > > > > > > > > > > About Apache HttpClient > > > > > > > > > > > > > > > > > > > > > > > > > > > > Although the java.net package provides basic > > > > > > functionality for > > > > > > > > > > > > accessing > > > > > > > > > > > > > > resources via HTTP, it doesn't provide the full > > > > > > flexibility or > > > > > > > > > > > > > > functionality needed by many applications. > > HttpClient > > > > > > seeks to > > > > > > > > fill > > > > > > > > > > > > this > > > > > > > > > > > > > > void by providing an efficient, up-to-date, and > > > > > > feature-rich > > > > > > > > > > package > > > > > > > > > > > > > > implementing the client side of the most recent > > HTTP > > > > > > standards > > > > > > > > and > > > > > > > > > > > > > > recommendations. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Designed for extension while providing robust > > support > > > > for > > > > > > the > > > > > > > > base > > > > > > > > > > HTTP > > > > > > > > > > > > > > protocol, HttpClient may be of interest to anyone > > > > building > > > > > > > > > > HTTP-aware > > > > > > > > > > > > > > client applications such as web browsers, web > > service > > > > > > clients, > > > > > > > > or > > > > > > > > > > > > > > systems that leverage or extend the HTTP protocol > > for > > > > > > > > distributed > > > > > > > > > > > > > > communication. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > > > > > To unsubscribe, e-mail: > > > > > > > > httpclient-users-unsubscr...@hc.apache.org > > > > > > > > > > > > > > For additional commands, e-mail: > > > > > > > > > > httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > > > To unsubscribe, e-mail: > > > > > > httpclient-users-unsubscr...@hc.apache.org > > > > > > > > > > > > For additional commands, e-mail: > > > > > > > > httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > > > To unsubscribe, e-mail: > > > > httpclient-users-unsubscr...@hc.apache.org > > > > > > > > > > For additional commands, e-mail: > > > > > > httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > To unsubscribe, e-mail: > > httpclient-users-unsubscr...@hc.apache.org > > > > > > > > For additional commands, e-mail: > > > > httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org > > > > > > For additional commands, e-mail: > > httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org > > > > For additional commands, e-mail: httpclient-users-h...@hc.apache.org > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org > > For additional commands, e-mail: httpclient-users-h...@hc.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org For additional commands, e-mail: httpclient-users-h...@hc.apache.org
