On Fri, 2013-04-26 at 08:47 +0100, sebb wrote: > On 25 April 2013 15:40, Oleg Kalnichevski <ol...@apache.org> wrote: > > > On Thu, 2013-04-25 at 15:26 +0100, sebb wrote: > > > On 25 April 2013 14:45, Oleg Kalnichevski <ol...@apache.org> wrote: > > > > > > > On Thu, 2013-04-25 at 13:28 +0100, sebb wrote: > > > > > On 25 April 2013 12:26, Oleg Kalnichevski <ol...@apache.org> wrote: > > > > > > > > > > > On Thu, 2013-04-25 at 12:13 +0100, sebb wrote: > > > > > > > On 25 April 2013 12:03, Oleg Kalnichevski <ol...@apache.org> > > wrote: > > > > > > > > > > > > > > > On Thu, 2013-04-25 at 11:40 +0100, sebb wrote: > > > > > > > > > On 25 April 2013 11:22, Oleg Kalnichevski <ol...@apache.org> > > > > wrote: > > > > > > > > > > > > > > > > > > > On Wed, 2013-04-24 at 21:34 +0200, Philippe Mouawad wrote: > > > > > > > > > > > Sorry Oleg, I mixed up my question. > > > > > > > > > > > > > > > > > > > > > > So does HTTPCLIENT-1340 affect 4.2.3 version of > > HttpClient ? > > > > I am > > > > > > > > > > confused > > > > > > > > > > > about JIRA indicating it affects 4.2.3 BETA which suggest > > > > 4.2.3 > > > > > > could > > > > > > > > > > also > > > > > > > > > > > be concerned. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The bug affects ALL versions of 4.2.x prior to 4.2.5 > > (including > > > > > > 4.2.3). > > > > > > > > > > It also affects deprecated code in 4.3 branch. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Are there any plans to fix the deprecated code? > > > > > > > > > I'm not saying we should, just wondering how to make the JIRA > > > > > > clearer. > > > > > > > > > > > > > > > > > > > > > > > > > Sebastian > > > > > > > > I did already back-port the fix to deprecated classes in 4.3 > > and > > > > > > clearly > > > > > > > > > > > > > > > > > > > > > > But you also wrote: > > > > > > > > > > > > > > "It also affects deprecated code in 4.3 branch." > > > > > > > > > > > > > > I cannot reconcile those two statements. > > > > > > > > > > > > > > > > > > > > > > > > > > My English certainly has its limits but I fail to see a > > contradiction > > > > in > > > > > > those statements. > > > > > > > > > > > > > > > [It's probably more a question of context/perspective than English, > > > > because > > > > > yours is better than quite a few native speakers! > > > > > I don't always immediately understand US English, because they > > ascribe > > > > > different meanings to some English words, e.g. pavement, table(verb)] > > > > > > > > > > I took the first sentence to mean that the deprecated classes in 4.3 > > have > > > > > been fixed (i.e. are not affected) > > > > > I took the second to mean that the deprecated code in 4.3 branch > > (i.e. > > > > > trunk) is still affected. > > > > > > > > > > That is the contradiction I could not understand, see further below. > > > > > > > > > > The bug affects all releases from the 4.3 branch > > > > > > (which is currently trunk). The bug has been fixed in SVN trunk by > > > > > > back-porting the fix from the 4.2 branch. > > > > > > > > > > > > > > > > > So I take it that the bug affects all existing 4.3 releases, but has > > > > I meant all deprecated code here, not the new code, but should have been > specific. > > > > > > since > > > > > been fixed in trunk and therefore the bug will be fixed in the next > > 4.3 > > > > > release? > > > > > Is that correct? > > > > > > > > > > > > > Yes and no. > > > > I was not sure, but I though the "no" could mean that the deprecated has > not been fixed in trunk. > > New connection management code in 4.3 has been pretty much > > > > completely rewritten and has diverged significantly from the original > > > > code affected by the bug. It never exhibited the said defect to start > > > > with. > > > > That bit I understood. > > > > Users of 4.3 who migrated off the deprecated API have nothing to > > > > worry about. > > > > In conjunction with my reading of "no", that last sentence made me wonder > if a user switching to the next version of 4.3 would encounter the bug if > they did not migrate off the deprecated API. > > > > > > > > > > > > > So does the deprecated code that remains in 4.3 still suffer from the > > bug? > > > > > > > So I asked the question above. > > > > > > > > > No, it does not. I back-ported the fix from 4.2 to 4.3 (deprecated code > > only). > > > > > This then confused me at first, but I think I see where the discrepancy is > now. > > My understanding is now: > > Users of existing 4.3 releases will only suffer from the bug if they use > deprecated code. > > When the next 4.3 release is made, users will not suffer from the bug even > if they don't migrate from the deprecated code. > > I hope that's correct now? >
That is absolutely correct. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org For additional commands, e-mail: httpclient-users-h...@hc.apache.org
