On Sun, 2007-04-22 at 10:32 +0200, Roland Weber wrote: > Hi Oleg, hi all, >
Hi Roland > Cookie: > The isExpired() method calls System.currentTimeMillis() > rather than comparing against an argument. This has some > implications which I don't like: > - it assumes that the system clock is the authoritative > source for the time to compare against, preventing code > from (pretending to) act in the past or future or based > on an external clock > - when scanning a set of cookies, the system time is > queried by each cookie. That call is not for free, and > it can return different values over time. I would much > prefer a single call to determine the system time, > passing the value to each comparison method afterwards. > The 3.x version of Cookie had a second isExpired() taking > a Date argument. Passing in the time to compare against > as a long would also be fine by me. > Of course such comparisons can be implemented externally. > But HttpState (see below) has a purgeExpiredCookies() > which is based on Cookie.isExpired() w/o argument. The > default behavior there should not be to get the system > time once for each cookie to consider. > Sounds reasonable. I'll get this fixed > HttpState: > We've talked about that during the High Level Design. > It's good enough for alpha1, but should be split into > it's different aspects afterwards. > I do think it is _really_ important to get ALPHA1 release out rather sooner then later. Port of HttpClient to HttpCore is a massive change by itself and is intended to address the most severe architectural issues with HttpClient. HttpState is somewhat ugly but not utterly broken the same way HttpMethod / HttpMethodBase are. Therefore I would rather have more test cases ported from 3.1 to 4.0 API and get the new framework reasonably tested and stable and only then get down to fixing non-critical aspects such as the HTTP state management API. What remains to be done for ALPHA1 in HttpConn? Oleg > cheers, > Roland > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
