[
https://issues.apache.org/jira/browse/HTTPCLIENT-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509445
]
Sebb commented on HTTPCLIENT-664:
---------------------------------
Perhaps change REV to REVISION?
The REV string will only get updated when the VersionInfo.java file is updated
in SVN, so I can't see the point.
Unless the idea is that this file will be updated immediately prior to a
release, in which case this should be documented in the file.
Also, why not simplify:
+ } catch (NumberFormatException ex) {
+ // shamelessly munch this exception
+ }
+ }
+ if (REV_VERSION == null) {
+ REV_VERSION = new Long(-1);
+ }
as
+ } catch (NumberFormatException ex) {
+ REV_VERSION = new Long(-1);
+ }
+ }
> Version detection based on build-time properties
> ------------------------------------------------
>
> Key: HTTPCLIENT-664
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-664
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Oleg Kalnichevski
> Fix For: 4.0 Alpha 2
>
> Attachments: httpclient-ver.patch
>
>
> Version detection based on build-time properties as discussed on the dev
> mailing list
> http://www.nabble.com/publishing-sources-to-the-maven-repo-tf3894418.html#a11048527
> http://www.nabble.com/-HttpClient--PATCH--Version-detection-tf4007519.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
