On Wed, Jun 17, 2009 at 12:31 AM, T. Modes <[email protected]> wrote:
> > > I think this case is very rare, because this one works only if the > second image has some EXIF data (make, model, focal length) to make > the comparision. But in this case the chances are high, that also the > exposure time and f-stop can be read from EXIF. So this one happens > probably only when the image contains corrupt EXIF data. > Hello, I'll have to review the code again, however I believe this is not the case. It might have been the intention, but the way the objects are being reused, only the filename is changed and then a call to re-load the EXIF data is made. Unfortunately, if there is no EXIF data the call returns without zeroing-out the previous files EXIF data. So the comparison makes a false positive thinking the EXIF data matches when indeed there isn't any data to match. It looked strange to me, but I thought it might be the someone's intent. If I patch the code to zero out the EXIF data before re-loading it, then the HFOV box pops up (as I would expect it to). I propose the following: 1. Be a bit more stringent in what gets copied/assumed from one image to the another. 2. Be more determinstic. The behaviour of what happens shouldn't change whether you add all the images at once, or one at a time 3. Remove the Load EXIF button. Update the "Reset..." Dialog to allow more things to be reset to either 0 or EXIF data. This would allow the user to re-compute the HFOV from EXIF without messing up the exposue value. Right now both happen when Load EXIF is pressed 4. If there is a mix in images with and without EXIF data, reset all images to 0 exposure along with the preview exposure. Or atleast give the user an indication of what might be happening instead of presenting either solid black or almost pure white images. Any thoughts? Best Regards, - Gerry --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx -~----------~----~----~----~------~----~------~--~---
