On 5 Feb., 12:06, "T. Modes" <[email protected]> wrote: > Commited after some changes. > * Don't misuse configure_file for installing files. Use the install > command instead.
Okay. I'm just now sure about how to go on about the installing on Linux. So far I'm just keeping the python modules and plugins in my target directory and put my PYTHONPATH variable to point to it. But really, the module should go to the system module path and the plugins should live in a dedicated plugin directory. I'd like some feedback on the issue, and I certainly don't want to just shove stuff into paths outside hugin's tree without due consideration. Would someone of the developers working on Linux please comment on the issue? > * Your patch contains a lot a line, where only the line ending were > changed. -> Unified Sorry for that. On Linux, every line ends with a newline character and nothing else. I don't know how other line endings made it into my code, I'll do my best to avoid this in the future. What standard do you use in the hugin repo? Do I have to put in carriage returns? > * Some changes in your patch were already in the repo. You did not > provide a patch against the head of the python branch. Again, sorry. I'm not sure how this happened. I drew a fresh clone once the patch was integrated, then modified that, and finally created the patch after a commit. Do I have to do more than that? Should I fetch a clean clone just before I patch, carry over my modifications to it and make the patch from that? > Also it would be nice, if one commit/changeset/patch would only > address one issue. Putting all changes into one changeset is not > recommended when using version management. This makes it harder to > track changes and to find bug. I wanted to kep the work load low for you guys who have to put the patch into the SF repo. Seems this backfired. But now I'm quite content that the groundwork is laid, and I'm going to slow down anyway and do a bit of something else too. So I'll do my best to stick to the one-patch-per-issue paradigm from now on. > > I also put in two SWIG interfaces, 'bogous.i' and 'vacine.i' which > > demonstrate a problem I have on my system (Kubuntu 10.10 + Python 2.6) > > and haven't been able to resolve > ... > See my above comments. For this issue it is better if you provide a > patch which contains only the interface bogous/vaccine, maybe with a > readme. Then it would be easier for someone else to apply your patch > and give feedback/solution. That's a good idea. I'm still new to Mercurial, and I'll take a while until I can use it proficiently. Please bear with me. Thanks again for your prompt response and for integrating my patch into the repo! Kay -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx
