>I had no problems with your patch. If nobody complains, I will soon commit. Ok.
>The inclusion 'include(CheckCXXCompilerFlag)' inside the macro: Makes sense. Should it rather be included in HuginMacros.cmake, or in CMakeLists.txt? On Sat, Sep 27, 2014 at 4:35 PM, Kornel Benko <[email protected]> wrote: > Am Donnerstag, 25. September 2014 um 10:10:55, schrieb Roman Lebedev < > [email protected]> > > Hi. > > > > Sure, if this is how it is preferred. (updated patch attached) > > > > Any chance to see it being merged into enblend hg repo? (preferably > keeping > > User line) > > Or this is the wrong place to submit patches? > > > > I had no problems with your patch. If nobody complains, I will > soon commit. > > The inclusion 'include(CheckCXXCompilerFlag)' inside the macro: > Sure, the macro is called exactly once, so there is no overhead. > And using it outside of the macro will execute the include it even if not > needed. > But for the sake of possible later check for another compiles flags, I > prefer to > have the assignment be outside. > > Kornel > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/CADoyv_6U%2BvZW7hJd-Cyg4mCsC12iMmVTCfvMnMb1xgv%3DzxLTrQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
