Am Samstag, 27. September 2014 um 16:44:34, schrieb Roman Lebedev 
<[email protected]>
> >I had no problems with your patch. If nobody complains, I will soon commit.
> Ok.
> 
> >The inclusion 'include(CheckCXXCompilerFlag)' inside the macro:
> Makes sense.
> Should it rather be included in HuginMacros.cmake, or in CMakeLists.txt?

I like it to be near the place, where it is needed. (1 line before macro 
creation in HuginMacros.cmake)
Alternatively at the prominent place (e.g. first lines in HuginMacros.cmake 
should include everything
needed by the following macros)

OTOH, ConfigureChecks.cmake already has some includes, so maybe everything 
should go there.
But as it is not used there, I still prefer HuginMacros.cmake.

> On Sat, Sep 27, 2014 at 4:35 PM, Kornel Benko <[email protected]>
> wrote:
> 
> > Am Donnerstag, 25. September 2014 um 10:10:55, schrieb Roman Lebedev <
> > [email protected]>
> > > Hi.
> > >
> > > Sure, if this is how it is preferred. (updated patch attached)
> > >
> > > Any chance to see it being merged into enblend hg repo? (preferably
> > keeping
> > > User line)
> > > Or this is the wrong place to submit patches?
> > >
> >
> > I had no problems with your patch. If nobody complains, I will
> > soon commit.
> >
> > The inclusion 'include(CheckCXXCompilerFlag)' inside the macro:
> > Sure, the macro is called exactly once, so there is no overhead.
> > And using it outside of the macro will execute the include it even if not
> > needed.
> > But for the sake of possible later check for another compiles flags, I
> > prefer to
> > have the assignment be outside.

        Kornel

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to