Now I'm back online again, sorry for the delay.
On 19.08.19 17:34, T. Modes wrote:
snip
There are still more changes in the patch.
What additional changes do you mean? I intended the patch to contain
- the removal of the executable flag in the file's permissions
- the removal of the shebangs
- the removal of crop_cp.py
Also all files are contained twice.
I don't know what you mean by that, can you explain?
Furthermore, I don't think that simply removing the shebang is the
correct solution. This is only an ugly hack.
I don't agree. We're talking about python code which is used as a plugin
for hugin. In this constellation, hugin (having been 'extended' to
contain a python interpreter) performs reading, interpretation and
execution of this code. Neither the shell nor any python interpreters
installed on the system are involved or needed. The 'shebang' is a hint
to a shell how to process code which is launched by the shell; it's not
part of python syntax (seen from the python side, it's merely a comment,
like the offending api-min and api-max tags). The shebangs which I
propose to remove from the python plugins are only useful if these
plugins are written to function on the command line of a shell as well,
so that one can simply launch them from a command line by writing
woa.py ...
instead of having to issue the more involved
python woa.py ...
or
python3 woa.py ...
So the 'shebang' is, like the executable permission, simply a matter of
convenience for executing these scripts from a shell environment. For
hugin plugins, this is not needed. You might use any bit of text with
any (or no) file extension and any permissions sufficient to let hugin
read the file, as long as it contains valid python code compatible with
the hugin script interface.
I'd like to add that the changes I propose (apart from removing
crop_cp.py) have little effect of hugin as such - my intention was to
help with the difficulties Terry (sorry, Terry, for talking about you in
the third person here) encountered trying to build a fedora package,
because the fedora package building tool choked on the content as-is.
Once Terry gets his repo situation sorted and manages to apply my patch,
he can say whether it solves his packaging problem, and if he can't
apply the patch we can discuss what is going wrong. My experience with
packaging for debian may not be applicable, but debian packages
typically live in their dedicated repo with any debian-specific patches
local to that repo, independent of upstream. Since I am not involved in
fedora packaging, I don't know how their procedure is, but I presume
it's not much different. So even if upstream (the hugin repo) does opt
not to remove shebangs and change permissions, Terry, as the fedora
package builder, may opt to do so in the content being packaged. This
might help him build a valid fedora package without having to wait for
upstream to make a decision concerning the matter.
I tried to avoid sending patches by explaining what I think needs to be
done, which is simply
- remove the shebangs
- remove execute permission from the python files
additionally I recommend to
- remove crop_cp.py
... but I was asked to provide a patch. Seems like my patch did not go
down well, sorry. I'll happily try again.
> This is only an ugly hack.
I think that this comment is opinionated and dismissive. 'Only' implies
that it is missing something important, and 'ugly' is hardly a
technically neutral attribute. I have previously, and now again, tried
to explain why I think that my proposed changes are technically sound,
and if you'd like to discuss the matter on this basis, please let's do so.
Kay
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to a topic in the
Google Groups "hugin and other free panoramic software" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/hugin-ptx/oSmt89pqPCg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
[email protected]
<mailto:[email protected]>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/abec238f-8614-4834-96dd-aeee28cc2135%40googlegroups.com
<https://groups.google.com/d/msgid/hugin-ptx/abec238f-8614-4834-96dd-aeee28cc2135%40googlegroups.com?utm_medium=email&utm_source=footer>.
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/237b700c-f708-a311-39d3-7a57cb6b5c15%40yahoo.com.
