Hello Kay,
On Mon, 22 Jul 2019 01:40:57 +1000, 'Kay F. Jahnke' via hugin and other
free panoramic software <[email protected]> wrote:
[snip]
What I mean is that the shebang is irrelevant for plugins. I think it's
only the build system complaining: it sees a python script, looks into
it and notices that the shebang is ambiguous. But since the python
interpreter linked into hugin processes the script, this is a non-issue.
Your patch satisfies the fedora build system, but it makes no difference
apart from that.
I attach a patch removing the shebangs and the api-min and api-max. I
did the patch with hg diff --git, hope that's all right. This patch
should fix both the api-check issue and the shebang problem, and removes
crop_cp.py which I think is no longer useful. It does not address the
enforcement of python3-only.
I've removed all my local changes from my repo and applied your patch and
attempted to rpmbuild in Fedora 30, with the following message when the
build failed...
Bytecompiling .py files below
/home/terry/rpmbuild/BUILDROOT/hugin-2019.1.0-0.2.20190723hg.fc30.x86_64/usr/lib/debug/usr/lib64/python2.7
using /usr/bin/python2.7
Bytecompiling .py files below
/home/terry/rpmbuild/BUILDROOT/hugin-2019.1.0-0.2.20190723hg.fc30.x86_64/usr/lib64/python2.7
using /usr/bin/python2.7
+ /usr/lib/rpm/brp-python-hardlink
+ /usr/lib/rpm/redhat/brp-mangle-shebangs
*** WARNING: ./usr/share/hugin/data/plugins/shooting_pattern.py is
executable but has empty or no shebang, removing executable bit
*** WARNING: ./usr/share/hugin/data/plugins/top_five.py is executable but
has empty or no shebang, removing executable bit
*** WARNING: ./usr/share/hugin/data/plugins/woa.py is executable but has
empty or no shebang, removing executable bit
*** WARNING: ./usr/share/hugin/data/plugins-templates/plugin_skeleton.py
is executable but has empty or no shebang, removing executable bit
*** WARNING: ./usr/share/hugin/data/plugins-templates/dual_use.py is
executable but has empty or no shebang, removing executable bit
*** ERROR: ambiguous python shebang in
/usr/lib64/python2.7/site-packages/hpi.py: #!/usr/bin/env python. Change
it to python3 (or python2) explicitly.
error: Bad exit status from /var/tmp/rpm-tmp.wFPWQa (%install)
Looks like that patch isn't all that is needed for a build in Fedora 30,
assuming I applied the patch correctly.
Not sure what 'removing executable bit' in the above warnings means.
Hope this helps.
I don't think I know enough about this business to do much more than test
like this.
Cheers,
--
Regards,
Terry Duell
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/op.z5c6kco1rs0ygh%40localhost.
